This repository has been archived by the owner on May 26, 2022. It is now read-only.
remove all uses of multiaddrs #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NATs only care about TCP/UDP and ports. Using multiaddrs here made this library really hard to work with correctly. Furthermore, this library doesn't _actually_ support specifying the internal IP address. However, we'd still _act_ like the internal IP address mattered. This caused all sorts of mismatches.
ghost
assigned
Stebalien
added a commit
to libp2p/go-libp2p
that referenced
this pull request
Mar 6, 2019
1. Update to work with libp2p/go-libp2p-nat#14. 2. Avoid observed addrs when our NAT tells us about external addrs. 3. Ignore bad addrs reported by our NAT. Substitute with observed addrs. 4. Fix #428.
Stebalien
added a commit
to libp2p/go-libp2p
that referenced
this pull request
Mar 6, 2019
1. Update to work with libp2p/go-libp2p-nat#14. 2. Avoid observed addrs when our NAT tells us about external addrs. 3. Ignore bad addrs reported by our NAT. Substitute with observed addrs. 4. Fix #428.
Stebalien
added a commit
to libp2p/go-libp2p
that referenced
this pull request
Mar 6, 2019
1. Update to work with libp2p/go-libp2p-nat#14. 2. Avoid observed addrs when our NAT tells us about external addrs. 3. Ignore bad addrs reported by our NAT. Substitute with observed addrs. 4. Fix #428.
Stebalien
added a commit
to libp2p/go-libp2p
that referenced
this pull request
Mar 6, 2019
1. Update to work with libp2p/go-libp2p-nat#14. 2. Avoid observed addrs when our NAT tells us about external addrs. 3. Ignore bad addrs reported by our NAT. Substitute with observed addrs. 4. Fix #428.
Stebalien
added a commit
to libp2p/go-libp2p
that referenced
this pull request
Mar 6, 2019
1. Update to work with libp2p/go-libp2p-nat#14. 2. Avoid observed addrs when our NAT tells us about external addrs. 3. Ignore bad addrs reported by our NAT. Substitute with observed addrs. 4. Fix #428.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NATs only care about TCP/UDP and ports. Using multiaddrs here made this library really hard to work with correctly.
Furthermore, this library doesn't actually support specifying the internal IP address. However, we'd still act like the internal IP address mattered. This caused all sorts of mismatches.